cloud-fan commented on a change in pull request #26509: [SPARK-29427][SQL] Add 
API to convert RelationalGroupedDataset to KeyValueGroupedDataset
URL: https://github.com/apache/spark/pull/26509#discussion_r346160710
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala
 ##########
 @@ -46,11 +47,13 @@ import org.apache.spark.sql.types.{NumericType, StructType}
  * @since 2.0.0
  */
 @Stable
-class RelationalGroupedDataset protected[sql](
-    private[sql] val df: DataFrame,
+class RelationalGroupedDataset[T] protected[sql](
 
 Review comment:
   This is a stable API, is it OK to add type parameter? @srowen @dongjoon-hyun 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to