dongjoon-hyun commented on a change in pull request #26509: [SPARK-29427][SQL]
Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset
URL: https://github.com/apache/spark/pull/26509#discussion_r346196835
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala
##########
@@ -46,11 +47,13 @@ import org.apache.spark.sql.types.{NumericType, StructType}
* @since 2.0.0
*/
@Stable
-class RelationalGroupedDataset protected[sql](
- private[sql] val df: DataFrame,
+class RelationalGroupedDataset[T] protected[sql](
Review comment:
Although the goal seems to extend `Dataset[Row]` to `Dataset[T]` in 3.0.0,
I'm not sure about this approach. Not only this change (the generic class),
line 51 also changes from `df: DataFrame` to `ds: Dataset[T]`. If there is some
3rd party classes extending this, this variable name and type change will break
those classes.
@viirya . Do we need this change for your original goal, `Add API ...`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
