wangyum commented on a change in pull request #26499: [SPARK-29869][SQL] Fix
the problem of HiveMetastoreCatalog#convertToLogicalRelation throws
AssertionError
URL: https://github.com/apache/spark/pull/26499#discussion_r346212874
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala
##########
@@ -362,29 +362,20 @@ class DataSourceWithHiveMetastoreCatalogSuite
}
}
- test("SPARK-29869: HiveMetastoreCatalog#convertToLogicalRelation throws
AssertionError") {
+ test("SPARK-29869: fix HiveMetastoreCatalog#convertToLogicalRelation throws
AssertionError") {
withTempPath(dir => {
val baseDir = s"${dir.getCanonicalFile.toURI.toString}/test"
- val partitionDir =
s"${dir.getCanonicalFile.toURI.toString}/test/dt=20191113"
- val file = new Path(partitionDir, "file.parquet")
- val fs = file.getFileSystem(new Configuration())
- fs.createNewFile(file)
- withTable("test") {
- withSQLConf(HiveUtils.CONVERT_METASTORE_PARQUET.key -> "true",
- SQLConf.PARALLEL_PARTITION_DISCOVERY_THRESHOLD.key -> "0") {
+ val partitionLikeDir =
s"${dir.getCanonicalFile.toURI.toString}/test/dt=20191113"
Review comment:
`val partitionLikeDir =
s"${dir.getCanonicalFile.toURI.toString}/test/dt=20191113"` -> `val
partitionLikeDir = s"$baseDir/dt=20191113"`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
