cloud-fan commented on a change in pull request #26507: [WIP][SQL][2.4] Parse
timestamps in microsecond precision in JSON datasource
URL: https://github.com/apache/spark/pull/26507#discussion_r346289967
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -1164,4 +1167,27 @@ object DateTimeUtils {
threadLocalTimestampFormat.remove()
threadLocalDateFormat.remove()
}
+
+ class MicrosCalendar(tz: TimeZone) extends GregorianCalendar(tz, Locale.US) {
+ def getMicros(digitsInFraction: Int): SQLTimestamp = {
+ val d = fields(Calendar.MILLISECOND) * MICROS_PER_SECOND
+ d / Decimal.POW_10(digitsInFraction)
+ }
+ }
+
+ class DateTimeParser(format: FastDateFormat, digitsInFraction: Int, cal:
MicrosCalendar) {
+ def parse(s: String): SQLTimestamp = {
+ cal.clear()
+ if (!format.parse(s, new ParsePosition(0), cal)) {
+ throw new IllegalArgumentException(s)
Review comment:
nit: we should say `'s' is an invalid timestamp`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
