Github user koeninger commented on the pull request:
https://github.com/apache/spark/pull/4384#issuecomment-73269084
Thanks for adding the java friendly kafka uitls methods.
Your original reason for wanting Array[Leader] rather than
Map[TopicAndPartition, Broker] was for java compatibility.
But since there are separate scala and java-specific KafkaUtils.createRDD
methods now, couldn't the scala one take a Map and the java one take a JMap?
As it stands currently, what is the meaning if someone passes in an array
with multiple Leader objects that have the same topic and partition but
different broker?
The first thing we do with the array of leaders is convert it to a
map...seems better to just take a map and avoid both the possibility of
confusion and the extra conversion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
