huaxingao commented on issue #26527: [SPARK-29691] ensure Param objects are valid in fit, transform URL: https://github.com/apache/spark/pull/26527#issuecomment-554046071 @JohnHBauer Thanks for the pull request! Seems to me that @BryanCutler meant not to extend the API to accept parameter names, but just raise an Error if the values in extra are not an instance of Param. Also for type checking, seems to me that it might be more straightforward to do type checking and raise error in ```fit```/```transform``` instead of going down to ```_copyValues```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
