JohnHBauer commented on issue #26527: [SPARK-29691] ensure Param objects are valid in fit, transform URL: https://github.com/apache/spark/pull/26527#issuecomment-554058531 Estimator.fit and Transformer.transform use a shared mechanism for copying parameters, both call Params.copy, the bulk of its implementation is in _copyValues. This is the right place to do this. I observe that fit and transform have already checked that the extra params are in a dict, so that check is superfluous. This doesn't change the published API, since the requirement that values be param objects is not documented.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
