HeartSaVioR commented on a change in pull request #26416: [SPARK-29779][CORE]
Compact old event log files and cleanup
URL: https://github.com/apache/spark/pull/26416#discussion_r346656001
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/EventLogFileWriters.scala
##########
@@ -113,9 +113,9 @@ abstract class EventLogFileWriter(
}
}
- protected def writeJson(json: String, flushLogger: Boolean = false): Unit = {
+ protected def writeLine(line: String, flushLogger: Boolean = false): Unit = {
// scalastyle:off println
- writer.foreach(_.println(json))
+ writer.foreach(_.println(line))
// scalastyle:on println
if (flushLogger) {
writer.foreach(_.flush())
Review comment:
I think that's already discussed in #22881 - if I interpreted correctly, we
turn off EC for event log by default, and turn on at users' own risk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
