cloud-fan commented on a change in pull request #26536: [SPARK-29907][SQL] Move
DELETE/UPDATE/MERGE relative rules to dmlStatementNoWith to support cte
URL: https://github.com/apache/spark/pull/26536#discussion_r346668422
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -784,6 +784,16 @@ class DDLParserSuite extends AnalysisTest {
Some(EqualTo(UnresolvedAttribute("t.a"), Literal(2)))))
}
+ test("delete from table: cte") {
+ parseCompare("WITH c(a) AS (SELECT 2) DELETE FROM testcat.ns1.ns2.tbl AS t
WHERE t.a = c.a",
+ With(DeleteFromTable(
Review comment:
It's pretty straightforward that the parser will wrap the plan with a
`With`, I think the part we need to verify is the analyzer. Can we move tests
to `PlanResolutionSuite` to test analyzing behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
