cloud-fan commented on a change in pull request #26491: [SPARK-29870][SQL]
Unify the logic of multi-units interval string to CalendarInterval
URL: https://github.com/apache/spark/pull/26491#discussion_r346683438
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -482,13 +409,17 @@ object IntervalUtils {
}
}
+ def nextWord: UTF8String = {
+ s.substring(i, s.numBytes()).subStringIndex(UTF8String.blankString(1), 1)
Review comment:
This is for error reporting, so perf doesn't matter. Can we make it more
readable? like
```
s.substring(i, s.numBytes()).toString.split("\\s+").head
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
