edrevo commented on a change in pull request #25945: [SPARK-29248][SQL] Pass in
number of partitions to WriteBuilder
URL: https://github.com/apache/spark/pull/25945#discussion_r346689861
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/MicroBatchWrite.scala
##########
@@ -36,8 +36,8 @@ class MicroBatchWrite(eppchId: Long, val writeSupport:
StreamingWrite) extends B
writeSupport.abort(eppchId, messages)
}
- override def createBatchWriterFactory(): DataWriterFactory = {
- new MicroBatchWriterFactory(eppchId,
writeSupport.createStreamingWriterFactory())
+ override def createBatchWriterFactory(numPartitions: Int): DataWriterFactory
= {
Review comment:
No problem! Since we still want to move forward with the interface-based
approach, I've decided to evolve https://github.com/apache/spark/pull/25990/ to
include both the `PhysicalWriteInfo` as well as `WriteInfo`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
