HyukjinKwon commented on a change in pull request #26279: [SPARK-28382][SQL]
Add array function - unnest
URL: https://github.com/apache/spark/pull/26279#discussion_r346692072
##########
File path:
sql/core/src/test/resources/sql-tests/inputs/postgreSQL/aggregates_part4.sql
##########
@@ -404,12 +403,8 @@
-- [SPARK-28382] Array Functions: unnest
-- check collation-sensitive matching between grouping expressions
--- select v||'a', case v||'a' when 'aa' then 1 else 0 end, count(*)
--- from unnest(array['a','b']) u(v)
--- group by v||'a' order by 1;
--- select v||'a', case when v||'a' = 'aa' then 1 else 0 end, count(*)
--- from unnest(array['a','b']) u(v)
--- group by v||'a' order by 1;
+select v||'a', case v||'a' when 'aa' then 1 else 0 end, count(*) from (select
unnest(array('a','b')) as v) u group by v||'a' order by 1;
+select v||'a', case when v||'a' = 'aa' then 1 else 0 end, count(*) from
(select unnest(array('a','b')) as v) u group by v||'a' order by 1;
Review comment:
Why should we inline them? can't we just uncomment the tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
