cloud-fan commented on a change in pull request #25990: [SPARK-29248][SQL][WIP]
Pass in number of partitions to WriteBuilder
URL: https://github.com/apache/spark/pull/25990#discussion_r346692667
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/streaming/StreamingWrite.java
##########
@@ -48,8 +49,10 @@
*
* If this method fails (by throwing an exception), the action will fail and
no Spark job will be
* submitted.
+ *
+ * @param writeInfo Information about the RDD that will be written to this
data writer
*/
- StreamingDataWriterFactory createStreamingWriterFactory();
+ StreamingDataWriterFactory createStreamingWriterFactory(PhysicalWriteInfo
writeInfo);
Review comment:
for simplicity, we can just call the parameter "info"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
