srowen commented on a change in pull request #26538: [SPARK-29127][SQL][PYTHON]
Add a clue for Python related version information in integrated UDF tests
URL: https://github.com/apache/spark/pull/26538#discussion_r346705167
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -384,7 +384,21 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
// This is a temporary workaround for SPARK-28894. The test names are
truncated after
// the last dot due to a bug in SBT. This makes easier to debug via
Jenkins test result
// report. See SPARK-28894.
- withClue(s"${testCase.name}${System.lineSeparator()}") {
+ // See also SPARK-29127. It is difficult to see the version information in
the failed test
+ // cases so the version information related to Python was also added.
+ val clue = testCase match {
+ case udfTestCase: UDFTest
+ if udfTestCase.udf.isInstanceOf[TestPythonUDF] &&
shouldTestPythonUDFs =>
+ s"${testCase.name}${System.lineSeparator()}Python:
$pythonVer${System.lineSeparator()}"
+ case udfTestCase: UDFTest
+ if udfTestCase.udf.isInstanceOf[TestScalarPandasUDF] &&
shouldTestScalarPandasUDFs =>
+ s"${testCase.name}${System.lineSeparator()}" +
Review comment:
Do you need this vs just a newline? no big deal anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
