srowen commented on a change in pull request #26282:
[SPARK-29619][PYTHON][CORE] Add retry times when reading the daemon port.
URL: https://github.com/apache/spark/pull/26282#discussion_r346713661
##########
File path:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala
##########
@@ -206,15 +206,28 @@ private[spark] class PythonWorkerFactory(pythonExec:
String, envVars: Map[String
workerEnv.put("PYTHON_WORKER_FACTORY_SECRET", authHelper.secret)
// This is equivalent to setting the -u flag; we use it because
ipython doesn't support -u:
workerEnv.put("PYTHONUNBUFFERED", "YES")
- daemon = pb.start()
-
- val in = new DataInputStream(daemon.getInputStream)
- try {
- daemonPort = in.readInt()
- } catch {
- case _: EOFException =>
- throw new SparkException(s"No port number in $daemonModule's
stdout")
Review comment:
Yes I also don't see a reason to retry, insofar as I don't see evidence that
it would make subsequent attempts succeed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
