vanzin commented on a change in pull request #25299: [SPARK-27651][Core] Avoid
the network when shuffle blocks are fetched from the same host
URL: https://github.com/apache/spark/pull/25299#discussion_r346953082
##########
File path:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala
##########
@@ -190,7 +218,8 @@ private[spark] class IndexShuffleBlockResolver(
}
}
- override def getBlockData(blockId: BlockId): ManagedBuffer = {
+ override def getBlockData(blockId: BlockId, dirs: Option[Array[String]])
+ : ManagedBuffer = {
Review comment:
I don't think there's an "official" style for this case; but this line
shouldn't be at the same indent level as the method implementation.
So I'd use the multi-line argument style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
