srowen edited a comment on issue #26548: [SPARK-29918][SQL] RecordBinaryComparator should check endianness when compared by long URL: https://github.com/apache/spark/pull/26548#issuecomment-554520499 Is https://issues.apache.org/jira/browse/SPARK-23207 actually the same issue? that was marked fixed. (Edited below to fix my example) So, hm, do we not also have a subtle problem with the signed nature of bytes and longs? Putting aside endianness issues, if you compare two longs starting with bytes like: 1000 0000 ... 0000 0000 ... The first is less than the second, because it's clearly negative while the other isn't. But comparing byte by byte, we'd consider the first one to be greater than the second. Would this also be an issue between aligned and unaligned machines? That said, I also don't know how common it is to mix this hardware? (I don't even know which machines do and don't support aligned access.) Is it common?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
