tgravescs commented on a change in pull request #26284: [SPARK-29415][Core]Stage Level Sched: Add base ResourceProfile and Request classes URL: https://github.com/apache/spark/pull/26284#discussion_r347022785
########## File path: core/src/main/scala/org/apache/spark/resource/TaskResourceRequests.scala ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.resource + +import scala.collection.mutable + +import org.apache.spark.resource.ResourceProfile._ +import org.apache.spark.resource.ResourceUtils._ + +/** + * A set of task resource requests. This is used in conjuntion with the ResourceProfile to + * programmatically specify the resources needed for an RDD that will be applied at the + * stage level. + * + * This api is currently private until the rest of the pieces are in place and then it + * will become public. + */ +private[spark] class TaskResourceRequests() extends Serializable { + + private val _taskResources = new mutable.HashMap[String, TaskResourceRequest]() + + def requests: Map[String, TaskResourceRequest] = _taskResources.toMap + + /** + * Specify number of cpus per Task. + * + * @param amount Number of cpus to allocate per Task. + */ + def cpus(amount: Int): this.type = { + val t = new TaskResourceRequest(CPUS, amount) + _taskResources(CPUS) = t + this + } + + /** + * Amount of a particular custom resource(GPU, FPGA, etc) to use. The resource names supported + * correspond to the regular Spark configs with the prefix removed. For instance, resources + * like GPUs are resource.gpu (spark configs spark.task.resource.gpu.*) + * + * @param resourceName Name of the resource. + * @param amount Amount requesting as a Double to support fractional resource requests. Review comment: less then 1 gpu really means I want X tasks per GPU. This use case is completely possible and we do this all the time. You can get performance wins when multiple spark tasks share the GPU because many times the data of 1 task is not enough to use the entire GPU and you can also overlap the copies to/from with the actual kernels running. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
