yaooqinn commented on a change in pull request #26418: [SPARK-29783][SQL]
Support SQL Standard/ISO_8601 output style for interval type
URL: https://github.com/apache/spark/pull/26418#discussion_r347089350
##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -88,3 +88,46 @@ select justify_interval(interval '1 month -59 day 25 hour');
select justify_days(interval '1 month 59 day -25 hour');
select justify_hours(interval '1 month 59 day -25 hour');
select justify_interval(interval '1 month 59 day -25 hour');
+
+-- interval output style
Review comment:
```
--SET spark.sql.intervalOutputStyle = SQL_STANDARD
--import interval-display.sql
```
these 2 don't fit each other well,
When regenerating golden files, the set operations will not happen,
considering this as a bug,
also cc @maropu
https://github.com/apache/spark/blob/40ea4a11d7f1534023669f0b81faf5d398174e46/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala#L288-L295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
