dongjoon-hyun commented on a change in pull request #26551: [SPARK-29858][SQL]
ALTER DATABASE (SET DBPROPERTIES) should look up catalog like v2 commands
URL: https://github.com/apache/spark/pull/26551#discussion_r347105158
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -1160,6 +1160,22 @@ class DDLParserSuite extends AnalysisTest {
DropNamespaceStatement(Seq("a", "b", "c"), ifExists = false, cascade =
true))
}
+ test("alter namespace set dbproperties") {
+ val sql1 = "ALTER DATABASE a.b.c SET DBPROPERTIES ('a'='a', 'b'='b',
'c'='c')"
+ val sql2 = "ALTER SCHEMA a.b.c SET DBPROPERTIES ('a'='a')"
+ val sql3 = "ALTER NAMESPACE a.b.c SET DBPROPERTIES ('b'='b')"
Review comment:
Can we have a test case for `PROPERTIES` too since this PR adds it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
