dongjoon-hyun commented on a change in pull request #26530: [SPARK-25694][SQL]
Add a config for `URL.setURLStreamHandlerFactory`
URL: https://github.com/apache/spark/pull/26530#discussion_r347171228
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -191,11 +194,15 @@ private[sql] class SharedState(
}
object SharedState extends Logging {
- try {
- URL.setURLStreamHandlerFactory(new FsUrlStreamHandlerFactory())
- } catch {
- case e: Error =>
- logWarning("URL.setURLStreamHandlerFactory failed to set
FsUrlStreamHandlerFactory")
+ private def setFsUrlStreamHandlerFactory(conf: SparkConf): Unit = {
+ if (conf.get(DEFAULT_URL_STREAM_HANDLER_FACTORY_ENABLED)) {
+ try {
+ URL.setURLStreamHandlerFactory(new FsUrlStreamHandlerFactory())
Review comment:
Sorry, I didn't understand what you meant. Do you want me to add the initial
approach? I'm okay to add back if you want.
> That, and simply relying on it being Error, so you have to handle it for
control flow, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
