dongjoon-hyun commented on a change in pull request #26564: [SPARK-29936][R][TESTS] Add lint-r GitHub Action URL: https://github.com/apache/spark/pull/26564#discussion_r347172018
########## File path: R/pkg/.lintr ########## @@ -1,2 +1,2 @@ -linters: with_defaults(line_length_linter(100), multiple_dots_linter = NULL, object_name_linter = NULL, camel_case_linter = NULL, open_curly_linter(allow_single_line = TRUE), closed_curly_linter(allow_single_line = TRUE)) +linters: with_defaults(line_length_linter(100), multiple_dots_linter = NULL, object_name_linter = NULL, camel_case_linter = NULL, open_curly_linter(allow_single_line = TRUE), closed_curly_linter(allow_single_line = TRUE), object_usage_linter = NULL) Review comment: `object_usage_linter` has a limitation which cannot detect `shell` function used in `Windows` environment. Also, `nolint` doesn't work for this rule. This is a known limitation of lint-r itself. - https://github.com/jimhester/lintr/issues/27 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
