dongjoon-hyun commented on a change in pull request #26564: [SPARK-29936][R]
Fix SparkR lint errors and add lint-r GitHub Action
URL: https://github.com/apache/spark/pull/26564#discussion_r347177763
##########
File path: R/pkg/R/utils.R
##########
@@ -750,7 +750,7 @@ launchScript <- function(script, combinedArgs, wait =
FALSE, stdout = "", stderr
if (.Platform$OS.type == "windows") {
scriptWithArgs <- paste(script, combinedArgs, sep = " ")
# on Windows, intern = F seems to mean output to the console.
(documentation on this is missing)
- shell(scriptWithArgs, translate = TRUE, wait = wait, intern = wait) #
nolint
+ shell(scriptWithArgs, translate = TRUE, wait = wait, intern = wait)
Review comment:
Yes. I verified that it doesn't work as you see in the previous GitHub run.
(Both online `nolint` and blocked `nolint start ~ nolint end`).
Instead, we exclude the root cause, rule `object_usage_linter`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
