dongjoon-hyun commented on a change in pull request #26530: [SPARK-25694][SQL]
Add a config for `URL.setURLStreamHandlerFactory`
URL: https://github.com/apache/spark/pull/26530#discussion_r347194685
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -191,11 +195,18 @@ private[sql] class SharedState(
}
object SharedState extends Logging {
- try {
- URL.setURLStreamHandlerFactory(new FsUrlStreamHandlerFactory())
- } catch {
- case e: Error =>
- logWarning("URL.setURLStreamHandlerFactory failed to set
FsUrlStreamHandlerFactory")
+ private val fsUrlStreamHandlerFactoryInitialized = new AtomicBoolean(false)
+
+ private def setFsUrlStreamHandlerFactory(conf: SparkConf): Unit = {
+ if (conf.get(DEFAULT_URL_STREAM_HANDLER_FACTORY_ENABLED) &&
+ fsUrlStreamHandlerFactoryInitialized.compareAndSet(false, true)) {
+ try {
+ URL.setURLStreamHandlerFactory(new FsUrlStreamHandlerFactory())
Review comment:
I'm also more familiar with the double-check pattern. As we see, the
original code (before AtomicBoolean) was double-check pattern with `volatile`
and `synchronized`. I'm fine to revert to that. If we use double-checked
pattern, `AtomicBoolean` is useless technically.
BTW, `fsUrlStreamHandlerFactoryInitialized` is inside `SharedState` object .
What do you mean by `new session`? The new thread also need to pass `getAndSet`
on the same `fsUrlStreamHandlerFactoryInitialized`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
