ulysses-you commented on a change in pull request #26565: [SPARK-29937][SQL]
Make FileSourceScanExec class fields lazy
URL: https://github.com/apache/spark/pull/26565#discussion_r347195734
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
##########
@@ -177,6 +177,8 @@ object FileSourceStrategy extends Strategy with Logging {
// Partition keys are not available in the statistics of the files.
val dataFilters =
normalizedFiltersWithoutSubqueries.filter(_.references.intersect(partitionSet).isEmpty)
+ logInfo(s"Pushed Filters: " +
+
s"${dataFilters.flatMap(DataSourceStrategy.translateFilter).mkString(",")}")
Review comment:
Before this pr, translateFilter is also run twice. This just reduce one
logging.
How about pass pushedDownFilters in `case class FileSourceScanExec()` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
