cloud-fan commented on a change in pull request #26562: [SPARK-29859][SQL]
ALTER DATABASE (SET LOCATION) should look up catalog like v2 commands
URL: https://github.com/apache/spark/pull/26562#discussion_r347200254
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -275,10 +275,19 @@ case class DescribeNamespace(
* command that works for v2 catalogs.
*/
case class AlterNamespaceSetProperties(
- catalog: CatalogPlugin,
+ catalog: SupportsNamespaces,
namespace: Seq[String],
properties: Map[String, String]) extends Command
+/**
+ * The logical plan of the ALTER (DATABASE|SCHEMA|NAMESPACE) ... SET LOCATION
+ * command that works for v2 catalogs.
+ */
+case class AlterNamespaceSetLocation(
Review comment:
See https://github.com/apache/spark/pull/26562#discussion_r347194089
Why can't we reuse `AlterNamespaceSetProperties`? It's OK to hardcode
"location".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
