shivsood commented on a change in pull request #26549: [SPARK-29644][SQL][2.4]
Corrected ShortType and ByteType mapping to SmallInt and TinyInt in JDBCUtils
URL: https://github.com/apache/spark/pull/26549#discussion_r347209517
##########
File path:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MsSqlServerIntegrationSuite.scala
##########
@@ -59,7 +59,7 @@ class MsSqlServerIntegrationSuite extends
DockerJDBCIntegrationSuite {
"""
|INSERT INTO numbers VALUES (
|0,
- |255, 32767, 2147483647, 9223372036854775807,
+ |127, 32767, 2147483647, 9223372036854775807,
Review comment:
Yes, all test cases including signed and unsigned are covered now for
ByteType and ShortType. Refer to test("SPARK-29644: Write tables with
ShortType") and test("SPARK-29644: Write tables with ByteType") in
JDBCWriteSuite.scala and MsSQLServerIntegrationSuite.scala.
Earlier it all worked as everything was treated as an integer. Every test
cases treated ByteType and ShortType as integers. These test are corrected now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
