cloud-fan commented on a change in pull request #26516: [SPARK-29893] improve
the local shuffle reader performance by changing the reading task number from 1
to multi.
URL: https://github.com/apache/spark/pull/26516#discussion_r347213557
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/LocalShuffledRowRDD.scala
##########
@@ -17,19 +17,23 @@
package org.apache.spark.sql.execution.adaptive
+import scala.collection.mutable.ArrayBuffer
+
import org.apache.spark._
import org.apache.spark.rdd.RDD
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.execution.metric.{SQLMetric,
SQLShuffleReadMetricsReporter}
-
/**
* The [[Partition]] used by [[LocalShuffledRowRDD]]. A pre-shuffle partition
* (identified by `preShufflePartitionIndex`) contains a range of post-shuffle
partitions
* (`startPostShufflePartitionIndex` to `endPostShufflePartitionIndex - 1`,
inclusive).
*/
private final class LocalShuffledRowRDDPartition(
Review comment:
Nit: we can keep the parameter name simple
```
case class LocalShuffledRowRDDPartition(
index: Int,
mapIndex: Int,
startPartition: Int,
endPartition: Int)
)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
