HyukjinKwon commented on a change in pull request #26549:
[SPARK-29644][SQL][2.4] Corrected ShortType and ByteType mapping to SmallInt
and TinyInt in JDBCUtils
URL: https://github.com/apache/spark/pull/26549#discussion_r347213679
##########
File path:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MsSqlServerIntegrationSuite.scala
##########
@@ -59,7 +59,7 @@ class MsSqlServerIntegrationSuite extends
DockerJDBCIntegrationSuite {
"""
|INSERT INTO numbers VALUES (
|0,
- |255, 32767, 2147483647, 9223372036854775807,
+ |127, 32767, 2147483647, 9223372036854775807,
Review comment:
I meant
1. This TINYINT seems able to contain unsigned values
(https://dev.mysql.com/doc/refman/8.0/en/integer-types.html) up to 255. How do
we handle?
2. Previously the value given here was `255` for `TINYINT` which is
performed via MySQL if I am not mistaken. How was this possible without
UNSIGNED keyword?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
