HeartSaVioR commented on a change in pull request #25987: [SPARK-29314][SS]
Don't overwrite the metric "updated" of state operator to 0 if empty batch is
run
URL: https://github.com/apache/spark/pull/25987#discussion_r329984407
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala
##########
@@ -795,7 +795,7 @@ class FlatMapGroupsWithStateSuite extends
StateStoreMetricsTest {
}
},
CheckNewAnswer(("c", "-1")),
- assertNumStateRows(total = 0, updated = 0)
+ assertNumStateRows(total = 0, updated = 1)
Review comment:
This represents the patch is correct fix, though total = 0, updated = 1
might make someone feeling odd. This is because FlatMapGroupsWithState counts
deletion of state as "update", whereas we don't count it as "update" in native
streaming aggregation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
