cloud-fan commented on a change in pull request #26519:
[SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI
SQL Tab
URL: https://github.com/apache/spark/pull/26519#discussion_r347245203
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala
##########
@@ -189,18 +191,19 @@ private[ui] class SparkPlanGraphCluster(
name: String,
desc: String,
val nodes: mutable.ArrayBuffer[SparkPlanGraphNode],
- metrics: Seq[SQLPlanMetric])
- extends SparkPlanGraphNode(id, name, desc, metrics) {
+ metrics: Seq[SQLPlanMetric],
+ codegenStageId: Option[Int] = None)
Review comment:
can we include the codegen id when building the `name`? Then we don't need
to change the class signature here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
