wangyum commented on a change in pull request #26557:
[SPARK-29873][SQL][Test][FOLLOWUP] set operations should not escape when regen
golden file with --SET --import both specified
URL: https://github.com/apache/spark/pull/26557#discussion_r347400311
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -285,7 +285,7 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
// When we are regenerating the golden files, we don't need to set any
config as they
// all need to return the same result
- if (regenerateGoldenFiles || !isTestWithConfigSets) {
+ if ((regenerateGoldenFiles && importedTestCaseName.isEmpty) ||
!isTestWithConfigSets) {
Review comment:
@cloud-fan To reduce the test time. The `mvn` test often timed out at that
time:
https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-maven-hadoop-2.7/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
