srowen commented on a change in pull request #26548: [SPARK-29918][SQL]
RecordBinaryComparator should check endianness when compared by long
URL: https://github.com/apache/spark/pull/26548#discussion_r347412238
##########
File path:
sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java
##########
@@ -108,7 +108,7 @@ private int compare(int index1, int index2) {
baseOffset2, recordLength2);
}
- private final RecordComparator binaryComparator = new
RecordBinaryComparator();
+ private final RecordComparator binaryComparator = new
RecordBinaryComparator(true);
Review comment:
... per the above comment, this wouldn't work on big-endian systems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
