JohnHBauer commented on issue #26527: [SPARK-29691][ML][PYTHON] ensure Param objects are valid in fit, transform URL: https://github.com/apache/spark/pull/26527#issuecomment-555154160 - Added a check to ParamGridBuilder.addGrid to enforce that keys be Param instances. Without the check, it's a generic CartesianProductBuilder. (The check in param.__init__._copyValues will also catch them, but only once fit is called.) - Removed string usage. (Validation of extra params would have had to be done by the first call to fit/transform. Doing the check in _copyValues is more robust.)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
