HyukjinKwon commented on a change in pull request #23400: [SPARK-26499] [SQL]
JdbcUtils.makeGetter does not handle ByteType
URL: https://github.com/apache/spark/pull/23400#discussion_r347712442
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
##########
@@ -693,6 +707,17 @@ class JDBCSuite extends QueryTest
JdbcDialects.unregisterDialect(testH2Dialect)
}
+ test("Map TINYINT to ByteType via JdbcDialects") {
+ JdbcDialects.registerDialect(testH2DialectTinyInt)
Review comment:
although it's a bit odd given
https://github.com/apache/spark/pull/23400#discussion_r347704641, at least this
test is scoped and won't affect other tests about unsigned `TINYINT` cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
