HeartSaVioR commented on issue #26590: [SPARK-29953][SS] Don't clean up source files for FileStreamSource if the files belong to the output of FileStreamSink URL: https://github.com/apache/spark/pull/26590#issuecomment-555327316 cc. @zsxwing Please also review the assumption here; > To simplify the condition, this patch assumes that if the source files belong to the FileStreamSink, the matched source path is the root of output directory for FileStreamSink. For example, suppose we provide a glob path /a/b/c/*/* and FileStreamSource processes the file /a/b/c/d/e/f/g/file. Then we only check /a/b/c/d/e to see whether there's FileStreamSink metadata log available. I can address the case if we would like to consider the case where metadata log is placed under subdirectory of glob path (like `/a/b/c/d/e/f/_spark_metadata`) or even placed under ancestor of glob path (like `/a/b/_spark_metadata`). I haven't address it yet because it would bring overheads, so would like to decide about a boundary and apply it afterwards.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
