cloud-fan commented on a change in pull request #26323: [SPARK-29657][CORE]
Iterator spill supporting radix sort with null prefix
URL: https://github.com/apache/spark/pull/26323#discussion_r347876971
##########
File path:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
##########
@@ -518,19 +520,52 @@ public int getNumRecords() {
public long spill() throws IOException {
Review comment:
low-level code is hard to review as nobody remembers all the details all the
time. Can you briefly explain the spill process to help people review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
