srowen commented on a change in pull request #26550:
[WIP][SPARK-29334][ML][MLLIB] Support for basic vector operators
URL: https://github.com/apache/spark/pull/26550#discussion_r347908384
##########
File path: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala
##########
@@ -186,6 +186,46 @@ sealed trait Vector extends Serializable {
*/
@Since("3.0.0")
def dot(v: Vector): Double = BLAS.dot(this, v)
+
+ /**
Review comment:
Seems reasonable. I'd generally prefer to focus on parity with Python; is
that what __add__ supports for example?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
