phpisciuneri commented on issue #26550: [WIP][SPARK-29334][ML][MLLIB] Support for basic vector operators URL: https://github.com/apache/spark/pull/26550#issuecomment-555534839 @srowen @zhengruifeng Thanks for the feedback! > I think the implementations could be further optimized, but I don't think it's vital now Yep, I definitely agree. When the time comes we can try a few different implementations and do a scaling analysis. > I wonder are there places in the code that can use these operations for clarity? I will search for usage of the wrapped BLAS routines and see. One thing to note, for example, is that `BLAS.axpy` is a function with side effects (the `y` arg is modified). So depending on how the routine is used in code, it might not make sense to substitute unless the `y` arg is copied before the call.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
