srowen commented on a change in pull request #26301: [SPARK-29644][SQL]
Corrected ShortType and ByteType mapping to SmallInt and TinyInt in JDBCUtils
URL: https://github.com/apache/spark/pull/26301#discussion_r347997172
##########
File path:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MsSqlServerIntegrationSuite.scala
##########
@@ -59,7 +59,7 @@ class MsSqlServerIntegrationSuite extends
DockerJDBCIntegrationSuite {
"""
|INSERT INTO numbers VALUES (
|0,
- |255, 32767, 2147483647, 9223372036854775807,
+ |127, 32767, 2147483647, 9223372036854775807,
Review comment:
So we have to use a widening conversion both ways. That's the safest thing
to do, I guess, and less of a change from the current behavior, where bytes go
all the way to ints.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
