Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4231#discussion_r24286510
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -1028,12 +1030,6 @@ object DecisionTree extends Serializable with
Logging {
// Categorical feature
val featureArity = metadata.featureArity(featureIndex)
if (metadata.isUnordered(featureIndex)) {
- // TODO: The second half of the bins are unused. Actually,
we could just use
- // splits and not build bins for unordered features.
That should be part of
- // a later PR since it will require changing other
code (using splits instead
- // of bins in a few places).
- // Unordered features
--- End diff --
Please keep these last 2 lines of comments. They are still relevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
