maropu commented on a change in pull request #26604: [SPARK-29968][SQL] Remove
the Predicate code from SparkPlan
URL: https://github.com/apache/spark/pull/26604#discussion_r348290883
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala
##########
@@ -471,28 +470,6 @@ abstract class SparkPlan extends QueryPlan[SparkPlan]
with Logging with Serializ
MutableProjection.create(expressions, inputSchema)
}
- private def genInterpretedPredicate(
- expression: Expression, inputSchema: Seq[Attribute]):
InterpretedPredicate = {
- val str = expression.toString
- val logMessage = if (str.length > 256) {
- str.substring(0, 256 - 3) + "..."
- } else {
- str
- }
- logWarning(s"Codegen disabled for this expression:\n $logMessage")
- InterpretedPredicate.create(expression, inputSchema)
Review comment:
Yea, `CodeGeneratorWithInterpretedFallback#createInterpretedObject ` does
the same thing with `genInterpretedPredicate `:
https://github.com/apache/spark/blob/5a70af7a6c271e12a1f8b508dcede804e30a1b75/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala#L63
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
