cloud-fan commented on a change in pull request #26604: [SPARK-29968][SQL]
Remove the Predicate code from SparkPlan
URL: https://github.com/apache/spark/pull/26604#discussion_r348313030
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/sources/SimpleTextRelation.scala
##########
@@ -88,7 +88,7 @@ class SimpleTextSource extends TextBasedFileFormat with
DataSourceRegister {
val attribute = inputAttributes.find(_.name == column).get
expressions.GreaterThan(attribute, literal)
}.reduceOption(expressions.And).getOrElse(Literal(true))
- InterpretedPredicate.create(filterCondition, inputAttributes)
+ Predicate.createInterpretedPredicate(filterCondition, inputAttributes)
Review comment:
This is a testing source, we don't care it's codegen or not. Should be fine
to call `Predicate.create`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
