cloud-fan commented on a change in pull request #26080: [SPARK-29425][SQL] The
ownership of a database should be respected
URL: https://github.com/apache/spark/pull/26080#discussion_r348333421
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -372,12 +372,44 @@ class HiveCatalogedDDLSuite extends DDLSuite with
TestHiveSingleton with BeforeA
assert(table.provider == Some("org.apache.spark.sql.hive.orc"))
}
}
+
+ test("Database Ownership") {
+ val catalog = spark.sessionState.catalog
+ try {
+ val dbName = "spark_29425"
+ val location = getDBPath(dbName)
+
+ sql(s"CREATE DATABASE $dbName")
+
+ checkAnswer(
+ sql(s"DESCRIBE DATABASE $dbName"),
+ Row("Database Name", dbName) ::
+ Row("Description", "") ::
+ Row("Location", CatalogUtils.URIToString(location)) ::
+ Row("Owner Name", Utils.getCurrentUserName()) ::
+ Row("Owner Type", "USER") :: Nil)
+
+ sql(s"ALTER DATABASE $dbName SET DBPROPERTIES ('a'='a', 'b'='b',
'c'='c')")
Review comment:
I'm not talking about this specific case but the general framework. What if
we need to add "lastAccessTime" later? We can't keep adding new fields and
break the API. Using properties is more future-proof.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
