cloud-fan commented on a change in pull request #26543: [SPARK-29911][SQL]
Uncache cached tables when session closed
URL: https://github.com/apache/spark/pull/26543#discussion_r348335010
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala
##########
@@ -75,6 +75,9 @@ private[hive] class SparkSQLSessionManager(hiveServer:
HiveServer2, sqlContext:
override def closeSession(sessionHandle: SessionHandle): Unit = {
HiveThriftServer2.listener.onSessionClosed(sessionHandle.getSessionId.toString)
+ val ctx =
sparkSqlOperationManager.sessionToContexts.getOrDefault(sessionHandle,
sqlContext)
+
ctx.sparkSession.sessionState.catalog.getTempViewNames().foreach(ctx.uncacheTable)
Review comment:
Ideally we should uncache the temp views when the session is closed, but
seems we don't have such an action called "close session" in Spark SQL.
`SparkSession.close` closes the SparkContext and thus closes all sessions.
If we have "close session" action in thrift server, I think it's corrected
to put the logic here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
