cloud-fan commented on a change in pull request #26612: [SPARK-29975][SQL] 
introduce --CONFIG_DIM directive
URL: https://github.com/apache/spark/pull/26612#discussion_r348646931
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/outer-join.sql
 ##########
 @@ -29,16 +36,10 @@ CREATE OR REPLACE TEMPORARY VIEW t1 AS SELECT * FROM 
VALUES (97) as t1(int_col1)
 
 CREATE OR REPLACE TEMPORARY VIEW t2 AS SELECT * FROM VALUES (0) as 
t2(int_col1);
 
--- Set the cross join enabled flag for the LEFT JOIN test since there's no 
join condition.
--- Ultimately the join should be optimized away.
-set spark.sql.crossJoin.enabled = true;
 
 Review comment:
   this is true by default now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to