dongjoon-hyun commented on a change in pull request #26612: [SPARK-29975][SQL] 
introduce --CONFIG_DIM directive
URL: https://github.com/apache/spark/pull/26612#discussion_r348701225
 
 

 ##########
 File path: 
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
 ##########
 @@ -104,9 +101,6 @@ class ThriftServerQueryTestSuite extends SQLQueryTestSuite 
{
     "subquery/in-subquery/simple-in.sql",
     "subquery/in-subquery/in-order-by.sql",
     "subquery/in-subquery/in-set-operations.sql",
 
 Review comment:
   Hi, @cloud-fan .
   This causes linter failure. Please remove the ending `,`.
   ```
   $ dev/lint-scala
   Scalastyle checks failed at following occurrences:
   [error] 
/Users/dongjoon/PRS/PR-26612/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala:
 illegal start of simple expression: Token(RPAREN,),3495,))
   [error] Total time: 20 s, completed Nov 20, 2019 11:24:55 AM
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to