jiangxb1987 commented on a change in pull request #26614: [SPARK-29976] New
conf for single task stage speculation
URL: https://github.com/apache/spark/pull/26614#discussion_r348863023
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -1778,6 +1778,48 @@ class TaskSetManagerSuite extends SparkFunSuite with
LocalSparkContext with Logg
assert(manager.resourceOffer("exec1", "host1", ANY).isEmpty)
}
+ private def testSingleTaskSpeculation(singleTaskEnabled: Boolean): Unit = {
+ sc = new SparkContext("local", "test")
+ // Set the speculation multiplier to be 0 so speculative tasks are
launched immediately
+ sc.conf.set(config.SPECULATION_MULTIPLIER, 0.0)
+ sc.conf.set(config.SPECULATION_ENABLED, true)
+ sc.conf.set(config.SPECULATION_SINGLETASKSTAGE_ENABLED, singleTaskEnabled)
+ // Set the threshold to be 60 minutes
+ sc.conf.set(config.SPECULATION_SINGLETASKSTAGE_DURATION_THRESHOLD.key,
"60min")
Review comment:
sounds good, let's keep the current way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
