HeartSaVioR commented on a change in pull request #26610: [SPARK-29973][SS] Use
nano time to avoid 'NaN'/'Infinity'
URL: https://github.com/apache/spark/pull/26610#discussion_r348875686
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ProgressReporter.scala
##########
@@ -178,7 +178,7 @@ trait ProgressReporter extends Logging {
id = id,
runId = runId,
name = name,
- timestamp = formatTimestamp(currentTriggerStartTimestamp),
+ timestamp = formatTimestamp(currentTriggerStartTimestamp /
NANOS_PER_MILLIS),
Review comment:
Looks like you didn't get what @srowen pointed out. `nanoTime` is not a
wall-clock - it is only effective when you calculate the difference between
twos to get elapsed time.
https://docs.oracle.com/javase/8/docs/api/java/lang/System.html#nanoTime--
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
