srowen commented on a change in pull request #26610: [SPARK-29973][SS] Use nano
time to avoid 'NaN'/'Infinity'
URL: https://github.com/apache/spark/pull/26610#discussion_r348879904
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ProgressReporter.scala
##########
@@ -178,7 +178,7 @@ trait ProgressReporter extends Logging {
id = id,
runId = runId,
name = name,
- timestamp = formatTimestamp(currentTriggerStartTimestamp),
+ timestamp = formatTimestamp(currentTriggerStartTimestamp /
NANOS_PER_MILLIS),
Review comment:
Yes, this is the point. We do want wall-clock time if the value 'escapes'
the JVM, as it does here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
